Add Debug implementations

acpi/src/bgrt.rs

@@ -4,7 +4,7 @@ use bit_field::BitField;
 /// The BGRT table contains information about a boot graphic that was displayed
 /// by firmware.
 #[repr(C, packed)]
-#[derive(Clone, Copy)]
+#[derive(Debug, Clone, Copy)]
 pub struct Bgrt {
     header: SdtHeader,
     pub version: u16,

acpi/src/fadt.rs

@@ -28,6 +28,7 @@ pub enum PowerProfile {
 /// always prefer the 64-bit one. Only if it's zero or the CPU will not allow us to access that
 /// address should the 32-bit one be used.
 #[repr(C, packed)]
+#[derive(Debug, Clone, Copy)]
 pub struct Fadt {
     header: SdtHeader,
 
@@ -344,7 +345,7 @@ impl Fadt {
     }
 }
 
-#[derive(Clone, Copy)]
+#[derive(Clone, Copy, Debug)]
 pub struct FixedFeatureFlags(u32);
 
 impl FixedFeatureFlags {
@@ -464,7 +465,7 @@ impl FixedFeatureFlags {
     }
 }
 
-#[derive(Clone, Copy)]
+#[derive(Clone, Copy, Debug)]
 pub struct IaPcBootArchFlags(u16);
 
 impl IaPcBootArchFlags {
@@ -501,7 +502,7 @@ impl IaPcBootArchFlags {
     }
 }
 
-#[derive(Clone, Copy)]
+#[derive(Clone, Copy, Debug)]
 pub struct ArmBootArchFlags(u16);
 
 impl ArmBootArchFlags {

acpi/src/hpet.rs

@@ -74,6 +74,7 @@ impl HpetInfo {
 }
 
 #[repr(C, packed)]
+#[derive(Debug, Clone, Copy)]
 pub struct HpetTable {
     /// The contents of the HPET's 'General Capabilities and ID register'
     header: SdtHeader,

acpi/src/lib.rs

@@ -97,6 +97,7 @@ pub enum AcpiError {
     InvalidGenericAddress,
 }
 
+#[derive(Debug)]
 pub struct AcpiTables<H>
 where
     H: AcpiHandler,
@@ -281,6 +282,7 @@ where
     }
 }
 
+#[derive(Debug)]
 pub struct Sdt {
     /// Physical address of the start of the SDT, including the header.
     pub physical_address: usize,

acpi/src/madt.rs

@@ -42,6 +42,7 @@ pub enum MadtError {
 ///     * The Streamlined Advanced Programmable Interrupt Controller (SAPIC) model (for Itanium systems)
 ///     * The Generic Interrupt Controller (GIC) model (for ARM systems)
 #[repr(C, packed)]
+#[derive(Debug, Clone, Copy)]
 pub struct Madt {
     header: SdtHeader,
     local_apic_address: u32,
@@ -270,6 +271,7 @@ impl Madt {
     }
 }
 
+#[derive(Debug)]
 pub struct MadtEntryIter<'a> {
     pointer: *const u8,
     /*
@@ -280,6 +282,7 @@ pub struct MadtEntryIter<'a> {
     _phantom: PhantomData<&'a ()>,
 }
 
+#[derive(Debug)]
 pub enum MadtEntry<'a> {
     LocalApic(&'a LocalApicEntry),
     IoApic(&'a IoApicEntry),
@@ -368,13 +371,14 @@ impl<'a> Iterator for MadtEntryIter<'a> {
     }
 }
 
-#[derive(Clone, Copy)]
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct EntryHeader {
     entry_type: u8,
     length: u8,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct LocalApicEntry {
     header: EntryHeader,
@@ -383,6 +387,7 @@ pub struct LocalApicEntry {
     flags: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct IoApicEntry {
     header: EntryHeader,
@@ -392,6 +397,7 @@ pub struct IoApicEntry {
     global_system_interrupt_base: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct InterruptSourceOverrideEntry {
     header: EntryHeader,
@@ -401,6 +407,7 @@ pub struct InterruptSourceOverrideEntry {
     flags: u16,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct NmiSourceEntry {
     header: EntryHeader,
@@ -408,6 +415,7 @@ pub struct NmiSourceEntry {
     global_system_interrupt: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct LocalApicNmiEntry {
     header: EntryHeader,
@@ -416,6 +424,7 @@ pub struct LocalApicNmiEntry {
     nmi_line: u8, // Describes which LINTn is the NMI connected to
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct LocalApicAddressOverrideEntry {
     header: EntryHeader,
@@ -425,6 +434,7 @@ pub struct LocalApicAddressOverrideEntry {
 
 /// If this entry is present, the system has an I/O SAPIC, which must be used instead of the I/O
 /// APIC.
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct IoSapicEntry {
     header: EntryHeader,
@@ -434,6 +444,7 @@ pub struct IoSapicEntry {
     io_sapic_address: u64,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct LocalSapicEntry {
     header: EntryHeader,
@@ -451,6 +462,7 @@ pub struct LocalSapicEntry {
     processor_uid_string: u8,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct PlatformInterruptSourceEntry {
     header: EntryHeader,
@@ -463,6 +475,7 @@ pub struct PlatformInterruptSourceEntry {
     platform_interrupt_source_flags: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct LocalX2ApicEntry {
     header: EntryHeader,
@@ -472,6 +485,7 @@ pub struct LocalX2ApicEntry {
     processor_uid: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct X2ApicNmiEntry {
     header: EntryHeader,
@@ -484,6 +498,7 @@ pub struct X2ApicNmiEntry {
 /// This field will appear for ARM processors that support ACPI and use the Generic Interrupt
 /// Controller. In the GICC interrupt model, each logical process has a Processor Device object in
 /// the namespace, and uses this structure to convey its GIC information.
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct GiccEntry {
     header: EntryHeader,
@@ -503,6 +518,7 @@ pub struct GiccEntry {
     _reserved2: [u8; 3],
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct GicdEntry {
     header: EntryHeader,
@@ -522,6 +538,7 @@ pub struct GicdEntry {
     _reserved2: [u8; 3],
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct GicMsiFrameEntry {
     header: EntryHeader,
@@ -533,6 +550,7 @@ pub struct GicMsiFrameEntry {
     spi_base: u16,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct GicRedistributorEntry {
     header: EntryHeader,
@@ -541,6 +559,7 @@ pub struct GicRedistributorEntry {
     discovery_range_length: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct GicInterruptTranslationServiceEntry {
     header: EntryHeader,
@@ -550,6 +569,7 @@ pub struct GicInterruptTranslationServiceEntry {
     _reserved2: u32,
 }
 
+#[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct MultiprocessorWakeupEntry {
     header: EntryHeader,

acpi/src/mcfg.rs

@@ -73,6 +73,12 @@ impl Mcfg {
     }
 }
 
+impl core::fmt::Debug for Mcfg {
+    fn fmt(&self, formatter: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+        formatter.debug_struct("Mcfg").field("header", &self.header).field("entries", &self.entries()).finish()
+    }
+}
+
 #[derive(Clone, Copy, Debug)]
 #[repr(C, packed)]
 pub struct McfgEntry {

acpi/src/platform/mod.rs

@@ -37,6 +37,7 @@ pub struct Processor {
     pub is_ap: bool,
 }
 
+#[derive(Debug)]
 pub struct ProcessorInfo {
     pub boot_processor: Processor,
     /// Application processors should be brought up in the order they're defined in this list.
@@ -44,6 +45,7 @@ pub struct ProcessorInfo {
 }
 
 /// Information about the ACPI Power Management Timer (ACPI PM Timer).
+#[derive(Debug)]
 pub struct PmTimer {
     /// A generic address to the register block of ACPI PM Timer.
     pub base: GenericAddress,
@@ -63,6 +65,7 @@ impl PmTimer {
 /// `PlatformInfo` allows the collection of some basic information about the platform from some of the fixed-size
 /// tables in a nice way. It requires access to the `FADT` and `MADT`. It is the easiest way to get information
 /// about the processors and interrupt controllers on a platform.
+#[derive(Debug)]
 pub struct PlatformInfo {
     pub power_profile: PowerProfile,
     pub interrupt_model: InterruptModel,

acpi/src/sdt.rs

@@ -3,7 +3,7 @@ use core::{fmt, mem, mem::MaybeUninit, str};
 
 /// Represents a field which may or may not be present within an ACPI structure, depending on the version of ACPI
 /// that a system supports. If the field is not present, it is not safe to treat the data as initialised.
-#[derive(Clone, Copy)]
+#[derive(Debug, Clone, Copy)]
 #[repr(transparent)]
 pub struct ExtendedField<T: Copy, const MIN_REVISION: u8>(MaybeUninit<T>);
 
@@ -95,7 +95,7 @@ impl<T: Copy, const MIN_REVISION: u8> ExtendedField<T, MIN_REVISION> {
 /// * WPBT - Windows Platform Binary Table
 /// * WSMT - Windows Security Mitigations Table
 /// * XENV - Xen Project
-#[derive(Clone, Copy)]
+#[derive(Debug, Clone, Copy)]
 #[repr(C, packed)]
 pub struct SdtHeader {
     pub signature: Signature,

aml/src/lib.rs

@@ -89,6 +89,7 @@ pub enum DebugVerbosity {
     All,
 }
 
+#[derive(Debug)]
 struct MethodContext {
     /// AML local variables. These are used when we invoke a control method. A `None` value represents a null AML
     /// object.
@@ -108,6 +109,7 @@ impl MethodContext {
     }
 }
 
+#[derive(Debug)]
 pub struct AmlContext {
     /// The `Handler` passed from the library user. This is stored as a boxed trait object simply to avoid having
     /// to add a lifetime and type parameter to `AmlContext`, as they would massively complicate the parser types.

rsdp/src/handler.rs

@@ -3,6 +3,7 @@ use core::{ops::Deref, ptr::NonNull};
 /// Describes a physical mapping created by `AcpiHandler::map_physical_region` and unmapped by
 /// `AcpiHandler::unmap_physical_region`. The region mapped must be at least `size_of::<T>()`
 /// bytes, but may be bigger.
+#[derive(Debug)]
 pub struct PhysicalMapping<H, T>
 where
     H: AcpiHandler,