Add fixed flags and boot architecture flags.

Add various other table signatures as specified in tables 5.5 and 5.6 of ACPI 6.4

Signed-off-by: Ethin Probst <ethindp@protonmail.com>

acpi/src/fadt.rs

@@ -92,14 +92,12 @@ pub struct Fadt {
     pub day_alarm: u8,
     pub month_alarm: u8,
     pub century: u8,
-    // TODO: expose through a type
-    iapc_boot_arch: u16,
+    pub iapc_boot_arch: IaPcBootArchFlags,
     _reserved2: u8, // must be 0
-    pub flags: Flags,
+    pub flags: FixedFeatureFlags,
     reset_reg: RawGenericAddress,
     pub reset_value: u8,
-    // TODO: expose through a type
-    arm_boot_arch: u16,
+    pub arm_boot_arch: ArmBootArchFlags,
     fadt_minor_version: u8,
     x_firmware_ctrl: ExtendedField<u64, 2>,
     x_dsdt_address: ExtendedField<u64, 2>,
@@ -340,11 +338,172 @@ impl Fadt {
 }
 
 #[derive(Clone, Copy)]
-// TODO: methods for other flags
-pub struct Flags(u32);
+pub struct FixedFeatureFlags(u32);
 
-impl Flags {
+impl FixedFeatureFlags {
+    /// If true, an equivalent to the x86 [WBINVD](https://www.felixcloutier.com/x86/wbinvd) instruction is supported.
+    /// All caches will be flushed and invalidated upon completion of this instruction,
+    /// and memory coherency is properly maintained. The cache *SHALL* only contain what OSPM references or allows to be cached.
+    pub fn supports_equivalent_to_wbinvd(&self) -> bool {
+        self.0.get_bit(0)
+    }
+
+    /// If true, [WBINVD](https://www.felixcloutier.com/x86/wbinvd) properly flushes all caches, but memory coherency is not maintained.
+    pub fn wbinvd_flushes_all_caches(&self) -> bool {
+        self.0.get_bit(1)
+    }
+
+    /// If true, all processors implement the C1 power state.
+    pub fn all_procs_support_c1_power_state(&self) -> bool {
+        self.0.get_bit(2)
+    }
+
+    /// If true, the C2 power state is configured to work on a uniprocessor and multiprocessor system.
+    pub fn c2_configured_for_mp_system(&self) -> bool {
+        self.0.get_bit(3)
+    }
+
+    /// If true, the power button is handled as a control method device.
+    /// If false, the power button is handled as a fixed-feature programming model.
+    pub fn power_button_is_control_method(&self) -> bool {
+        self.0.get_bit(4)
+    }
+
+    /// If true, the sleep button is handled as a control method device.
+    /// If false, the sleep button is handled as a fixed-feature programming model.
+    pub fn sleep_button_is_control_method(&self) -> bool {
+        self.0.get_bit(5)
+    }
+
+    /// If true, the RTC wake status is supported in fixed register space.
+    pub fn rtc_wake_in_fixed_register_space(&self) -> bool {
+        self.0.get_bit(6)
+    }
+
+    /// If true, the RTC alarm function can wake the system from an S4 sleep state.
+    pub fn rtc_wakes_system_from_s4(&self) -> bool {
+        self.0.get_bit(7)
+    }
+
+    /// If true, indicates that the PM timer is a 32-bit value.
     pub fn pm_timer_is_32_bit(&self) -> bool {
         self.0.get_bit(8)
     }
+
+    /// If true, the system supports docking.
+    pub fn supports_docking(&self) -> bool {
+        self.0.get_bit(9)
+    }
+
+    /// If true, the system supports system reset via the reset_reg field of the FADT.
+    pub fn supports_system_reset_via_fadt(&self) -> bool {
+        self.0.get_bit(10)
+    }
+
+    /// If true, the system supports no expansion capabilities and the case is sealed.
+    pub fn case_is_sealed(&self) -> bool {
+        self.0.get_bit(11)
+    }
+
+    /// If true, the system cannot detect the monitor or keyboard/mouse devices.
+    pub fn system_is_headless(&self) -> bool {
+        self.0.get_bit(12)
+    }
+
+    /// If true, OSPM must use a processor instruction after writing to the SLP_TYPx register.
+    pub fn use_instr_after_write_to_slp_typx(&self) -> bool {
+        self.0.get_bit(13)
+    }
+
+    /// If set, the platform supports the `PCIEXP_WAKE_STS` and `PCIEXP_WAKE_EN` bits in the PM1 status and enable registers.
+    pub fn supports_pciexp_wake_in_pm1(&self) -> bool {
+        self.0.get_bit(14)
+    }
+
+    /// If true, OSPM should use the ACPI power management timer or HPET for monotonically-decreasing timers.
+    pub fn use_pm_or_hpet_for_monotonically_decreasing_timers(&self) -> bool {
+        self.0.get_bit(15)
+    }
+
+    /// If true, the contents of the `RTC_STS` register are valid after wakeup from S4.
+    pub fn rtc_sts_is_valid_after_wakeup_from_s4(&self) -> bool {
+        self.0.get_bit(16)
+    }
+
+    /// If true, the platform supports OSPM leaving GPE wake events armed prior to an S5 transition.
+    pub fn ospm_may_leave_gpe_wake_events_armed_before_s5(&self) -> bool {
+        self.0.get_bit(17)
+    }
+
+    /// If true, all LAPICs must be configured using the cluster destination model when delivering interrupts in logical mode.
+    pub fn lapics_must_use_cluster_model_for_logical_mode(&self) -> bool {
+        self.0.get_bit(18)
+    }
+
+    /// If true, all LXAPICs must be configured using physical destination mode.
+    pub fn local_xapics_must_use_physical_destination_mode(&self) -> bool {
+        self.0.get_bit(19)
+    }
+
+    /// If true, this system is a hardware-reduced ACPI platform, and software methods are used for fixed-feature functions defined in chapter 4 of the ACPI specification.
+    pub fn system_is_hw_reduced_acpi(&self) -> bool {
+        self.0.get_bit(20)
+    }
+
+    /// If true, the system can achieve equal or better power savings in an S0 power state, making an S3 transition useless.
+    pub fn no_benefit_to_s3(&self) -> bool {
+        self.0.get_bit(21)
+    }
+}
+
+#[derive(Clone, Copy)]
+pub struct IaPcBootArchFlags(u16);
+
+impl IaPcBootArchFlags {
+    /// If true, legacy user-accessible devices are available on the LPC and/or ISA buses.
+    pub fn legacy_devices_are_accessible(&self) -> bool {
+        self.0.get_bit(0)
+    }
+
+    /// If true, the motherboard exposes an IO port 60/64 keyboard controller, typically implemented as an 8064 microcontroller.
+    pub fn motherboard_implements_8042(&self) -> bool {
+        self.0.get_bit(1)
+    }
+
+    /// If true, OSPM must not blindly probe VGA hardware.
+    /// VGA hardware is at MMIO addresses A0000h-BFFFFh and IO ports 3B0h-3BBh and 3C0h-3DFh.
+    pub fn dont_probe_vga(&self) -> bool {
+        self.0.get_bit(2)
+    }
+
+    /// If true, OSPM must not enable message-signaled interrupts.
+    pub fn dont_enable_msi(&self) -> bool {
+        self.0.get_bit(3)
+    }
+
+    /// If true, OSPM must not enable PCIe ASPM control.
+    pub fn dont_enable_pcie_aspm(&self) -> bool {
+        self.0.get_bit(4)
+    }
+
+    /// If true, OSPM must not use the RTC via its IO ports either because it isn't implemented or is at other addresses;
+    /// instead, OSPM *MUST* use the time and alarm namespace device control method.
+    pub fn use_time_and_alarm_namespace_for_rtc(&self) -> bool {
+        self.0.get_bit(5)
+    }
+}
+
+#[derive(Clone, Copy)]
+pub struct ArmBootArchFlags(u16);
+
+impl ArmBootArchFlags {
+    /// If true, the system implements PSCI.
+    pub fn implements_psci(&self) -> bool {
+        self.0.get_bit(0)
+    }
+
+    /// If true, OSPM must use HVC instead of SMC as the PSCI conduit.
+    pub fn use_hvc_as_psci_conduit(&self) -> bool {
+        self.0.get_bit(1)
+    }
 }

acpi/src/sdt.rs

@@ -23,39 +23,77 @@ impl<T: Copy, const MIN_REVISION: u8> ExtendedField<T, MIN_REVISION> {
 /// All SDTs share the same header, and are `length` bytes long. The signature tells us which SDT
 /// this is.
 ///
-/// The ACPI Spec (Version 6.2) defines the following SDT signatures:
-///     "APIC" - Multiple APIC Descriptor Table (MADT)
-///     "BGRT" - Boot Graphics Resource Table
-///     "BERT" - Boot Error Record Table
-///     "CPEP" - Corrected Platform Error Polling Table
-///     "DSDT" - Differentiated System Descriptor Table
-///     "ECDT" - Embedded Controller Boot Resources Table
-///     "EINJ" - Error Injection Table
-///     "ERST" - Error Record Serialization Table
-///     "FACP" - Fixed ACPI Description Table (FADT)
-///     "FACS" - Firmware ACPI Control Structure
-///     "FPDT" - Firmware Performance Data Table
-///     "GTDT" - Generic Timer Description Table
-///     "HEST" - Hardware Error Source Table
-///     "HMAT" - Heterogeneous Memory Attributes Table
-///     "MSCT" - Maximum System Characteristics Table
-///     "MPST" - Memory Power State Table
-///     "NFIT" - NVDIMM Firmware Interface Table
-///     "OEMx" - Various OEM-specific tables
-///     "PDTT" - Platform Debug Trigger Table
-///     "PMTT" - Platform Memory Topology Table
-///     "PPTT" - Processor Properties Topology Table
-///     "PSDT" - Persistent System Description Table
-///     "RASF" - ACPI RAS Feature Table
-///     "RSDT" - Root System Descriptor Table
-///     "SBST" - Smart Battery Specification Table
-///     "SLIT" - System Locality Information Table
-///     "SRAT" - System Resource Affinity Table
-///     "SSDT" - Secondary System Description Table
-///     "XSDT" - eXtended System Descriptor Table
+/// The ACPI Spec (Version 6.4) defines the following SDT signatures:
 ///
-/// We've come across some more ACPI tables in the wild:
-///     "WAET" - Windows ACPI Emulated device Table
+/// * APIC - Multiple APIC Description Table (MADT)
+/// *BERT - Boot Error Record Table
+/// *BGRT - Boot Graphics Resource Table
+/// *CPEP - Corrected Platform Error Polling Table
+/// *DSDT - Differentiated System Description Table (DSDT)
+/// *ECDT - Embedded Controller Boot Resources Table
+/// *EINJ - Error Injection Table
+/// *ERST - Error Record Serialization Table
+/// *FACP - Fixed ACPI Description Table (FADT)
+/// *FACS - Firmware ACPI Control Structure
+/// *FPDT - Firmware Performance Data Table
+/// *GTDT - Generic Timer Description Table
+/// *HEST - Hardware Error Source Table
+/// *MSCT - Maximum System Characteristics Table
+/// *MPST - Memory Power StateTable
+/// *NFIT - NVDIMM Firmware Interface Table
+/// *OEMx - OEM Specific Information Tables
+/// *PCCT - Platform Communications Channel Table
+/// *PHAT - Platform Health Assessment Table
+/// *PMTT - Platform Memory Topology Table
+/// *PSDT - Persistent System Description Table
+/// *RASF - ACPI RAS Feature Table
+/// *RSDT - Root System Description Table
+/// *SBST - Smart Battery Specification Table
+/// *SDEV - Secure DEVices Table
+/// *SLIT - System Locality Distance Information Table
+/// *SRAT - System Resource Affinity Table
+/// *SSDT - Secondary System Description Table
+/// *XSDT - Extended System Description Table
+///
+/// Acpi reserves the following signatures and the specifications for them can be found [here](https://uefi.org/acpi):
+///
+/// *AEST - ARM Error Source Table
+/// *BDAT - BIOS Data ACPI Table
+/// *CDIT - Component Distance Information Table
+/// *CEDT - CXL Early Discovery Table
+/// *CRAT - Component Resource Attribute Table
+/// *CSRT - Core System Resource Table
+/// *DBGP - Debug Port Table
+/// *DBG2 - Debug Port Table 2 (note: ACPI 6.4 defines this as "DBPG2" but this is incorrect)
+/// *DMAR - DMA Remapping Table
+/// *DRTM -Dynamic Root of Trust for Measurement Table
+/// *ETDT - Event Timer Description Table (obsolete, superseeded by HPET)
+/// *HPET - IA-PC High Precision Event Timer Table
+/// *IBFT - iSCSI Boot Firmware Table
+/// *IORT - I/O Remapping Table
+/// *IVRS - I/O Virtualization Reporting Structure
+/// *LPIT - Low Power Idle Table
+/// *MCFG - PCI Express Memory-mapped Configuration Space base address description table
+/// *MCHI - Management Controller Host Interface table
+/// *MPAM - ARM Memory Partitioning And Monitoring table
+/// *MSDM - Microsoft Data Management Table
+/// *PRMT - Platform Runtime Mechanism Table
+/// *RGRT - Regulatory Graphics Resource Table
+/// *SDEI - Software Delegated Exceptions Interface table
+/// *SLIC - Microsoft Software Licensing table
+/// *SPCR - Microsoft Serial Port Console Redirection table
+/// *SPMI - Server Platform Management Interface table
+/// *STAO - _STA Override table
+/// *SVKL - Storage Volume Key Data table (Intel TDX only)
+/// *TCPA - Trusted Computing Platform Alliance Capabilities Table
+/// *TPM2 - Trusted Platform Module 2 Table
+/// *UEFI - Unified Extensible Firmware Interface Specification table
+/// *WAET - Windows ACPI Emulated Devices Table
+/// *WDAT - Watch Dog Action Table
+/// *WDRT - Watchdog Resource Table
+/// *WPBT - Windows Platform Binary Table
+/// *WSMT - Windows Security Mitigations Table
+/// *XENV - Xen Project
 #[derive(Clone, Copy)]
 #[repr(C, packed)]
 pub struct SdtHeader {
@@ -73,7 +111,7 @@ pub struct SdtHeader {
 impl SdtHeader {
     /// Check that:
     ///     a) The signature matches the one given
-    ///     b) The checksum of the SDT
+    ///     b) The checksum of the SDT is valid
     ///
     /// This assumes that the whole SDT is mapped.
     pub fn validate(&self, signature: Signature) -> Result<(), AcpiError> {
@@ -129,6 +167,64 @@ impl Signature {
     pub const MADT: Signature = Signature(*b"APIC");
     pub const MCFG: Signature = Signature(*b"MCFG");
     pub const SSDT: Signature = Signature(*b"SSDT");
+    pub const BERT: Signature = Signature(*b"BERT");
+    pub const BGRT: Signature = Signature(*b"BGRT");
+    pub const CPEP: Signature = Signature(*b"CPEP");
+    pub const DSDT: Signature = Signature(*b"DSDT");
+    pub const ECDT: Signature = Signature(*b"ECDT");
+    pub const EINJ: Signature = Signature(*b"EINJ");
+    pub const ERST: Signature = Signature(*b"ERST");
+    pub const FACS: Signature = Signature(*b"FACS");
+    pub const FPDT: Signature = Signature(*b"FPDT");
+    pub const GTDT: Signature = Signature(*b"GTDT");
+    pub const HEST: Signature = Signature(*b"HEST");
+    pub const MSCT: Signature = Signature(*b"MSCT");
+    pub const MPST: Signature = Signature(*b"MPST");
+    pub const NFIT: Signature = Signature(*b"NFIT");
+    pub const PCCT: Signature = Signature(*b"PCCT");
+    pub const PHAT: Signature = Signature(*b"PHAT");
+    pub const PMTT: Signature = Signature(*b"PMTT");
+    pub const PSDT: Signature = Signature(*b"PSDT");
+    pub const RASF: Signature = Signature(*b"RASF");
+    pub const SBST: Signature = Signature(*b"SBST");
+    pub const SDEV: Signature = Signature(*b"SDEV");
+    pub const SLIT: Signature = Signature(*b"SLIT");
+    pub const SRAT: Signature = Signature(*b"SRAT");
+    pub const AEST: Signature = Signature(*b"AEST");
+    pub const BDAT: Signature = Signature(*b"BDAT");
+    pub const CDIT: Signature = Signature(*b"CDIT");
+    pub const CEDT: Signature = Signature(*b"CEDT");
+    pub const CRAT: Signature = Signature(*b"CRAT");
+    pub const CSRT: Signature = Signature(*b"CSRT");
+    pub const DBGP: Signature = Signature(*b"DBGP");
+    pub const DBG2: Signature = Signature(*b"DBG2");
+    pub const DMAR: Signature = Signature(*b"DMAR");
+    pub const DRTM: Signature = Signature(*b"DRTM");
+    pub const ETDT: Signature = Signature(*b"ETDT");
+    pub const IBFT: Signature = Signature(*b"IBFT");
+    pub const IORT: Signature = Signature(*b"IORT");
+    pub const IVRS: Signature = Signature(*b"IVRS");
+    pub const LPIT: Signature = Signature(*b"LPIT");
+    pub const MCHI: Signature = Signature(*b"MCHI");
+    pub const MPAM: Signature = Signature(*b"MPAM");
+    pub const MSDM: Signature = Signature(*b"MSDM");
+    pub const PRMT: Signature = Signature(*b"PRMT");
+    pub const RGRT: Signature = Signature(*b"RGRT");
+    pub const SDEI: Signature = Signature(*b"SDEI");
+    pub const SLIC: Signature = Signature(*b"SLIC");
+    pub const SPCR: Signature = Signature(*b"SPCR");
+    pub const SPMI: Signature = Signature(*b"SPMI");
+    pub const STAO: Signature = Signature(*b"STAO");
+    pub const SVKL: Signature = Signature(*b"SVKL");
+    pub const TCPA: Signature = Signature(*b"TCPA");
+    pub const TPM2: Signature = Signature(*b"TPM2");
+    pub const UEFI: Signature = Signature(*b"UEFI");
+    pub const WAET: Signature = Signature(*b"WAET");
+    pub const WDAT: Signature = Signature(*b"WDAT");
+    pub const WDRT: Signature = Signature(*b"WDRT");
+    pub const WPBT: Signature = Signature(*b"WPBT");
+    pub const WSMT: Signature = Signature(*b"WSMT");
+    pub const XENV: Signature = Signature(*b"XENV");
 
     pub fn as_str(&self) -> &str {
         str::from_utf8(&self.0).unwrap()