Explorar o código

Use is_empty instead of len comparisons.

Bruce Mitchener %!s(int64=7) %!d(string=hai) anos
pai
achega
14adf30a11
Modificáronse 3 ficheiros con 5 adicións e 5 borrados
  1. 2 2
      src/disassembler.rs
  2. 2 2
      src/lib.rs
  3. 1 1
      src/verifier.rs

+ 2 - 2
src/disassembler.rs

@@ -154,7 +154,7 @@ pub fn to_insn_vec(prog: &[u8]) -> Vec<HLInsn> {
         panic!("[Disassembler] Error: eBPF program length must be a multiple of {:?} octets",
                ebpf::INSN_SIZE);
     }
-    if prog.len() == 0 {
+    if prog.is_empty() {
         return vec![];
     }
 
@@ -339,7 +339,7 @@ pub fn disassemble(prog: &[u8]) {
         panic!("[Disassembler] Error: eBPF program length must be a multiple of {:?} octets",
                ebpf::INSN_SIZE);
     }
-    if prog.len() == 0 {
+    if prog.is_empty() {
         return;
     }
 

+ 2 - 2
src/lib.rs

@@ -237,10 +237,10 @@ impl<'a> EbpfVmMbuff<'a> {
         let mut reg: [u64;11] = [
             0, 0, 0, 0, 0, 0, 0, 0, 0, 0, stack.as_ptr() as u64 + stack.len() as u64
         ];
-        if mbuff.len() > 0 {
+        if !mbuff.is_empty() {
             reg[1] = mbuff.as_ptr() as u64;
         }
-        else if mem.len() > 0 {
+        else if !mem.is_empty() {
             reg[1] = mem.as_ptr() as u64;
         }
 

+ 1 - 1
src/verifier.rs

@@ -35,7 +35,7 @@ fn check_prog_len(prog: &[u8]) {
                ebpf::PROG_MAX_INSNS, prog.len() / ebpf::INSN_SIZE);
     }
 
-    if prog.len() == 0 {
+    if prog.is_empty() {
         panic!("[Verifier] Error: program does not end with “EXIT” instruction");
     }
     let last_insn = ebpf::get_insn(prog, (prog.len() / ebpf::INSN_SIZE) - 1);