Browse Source

Merge pull request #648 from rust-lang/detailed-mcp-message

More detailed Zulip announcement message for major changes
Mark Rousskov 4 năm trước cách đây
mục cha
commit
9169939e45
2 tập tin đã thay đổi với 15 bổ sung6 xóa
  1. 1 0
      src/config.rs
  2. 14 6
      src/handlers/major_change.rs

+ 1 - 0
src/config.rs

@@ -126,6 +126,7 @@ pub(crate) struct NotifyZulipLabelConfig {
 
 #[derive(PartialEq, Eq, Debug, serde::Deserialize)]
 pub(crate) struct MajorChangeConfig {
+    pub(crate) zulip_ping: String,
     pub(crate) second_label: String,
     pub(crate) meeting_label: String,
     pub(crate) zulip_stream: u64,

+ 14 - 6
src/handlers/major_change.rs

@@ -122,7 +122,8 @@ async fn handle_input(
             }
 
             (format!(
-                "@*T-compiler*: Proposal [#{}]({}) has been seconded, and will be approved in 10 days if no objections are raised.",
+                "@*{}*: Proposal [#{}]({}) has been seconded, and will be approved in 10 days if no objections are raised.",
+                config.zulip_ping,
                 issue.number,
                 event.html_url().unwrap()
             ), config.second_label.clone())
@@ -136,11 +137,18 @@ async fn handle_input(
                 cmnt.post(&ctx.github).await?;
                 return Ok(());
             }
-            (format!(
-                "A new proposal has been announced: [#{}]({}). It will be brought up at the next meeting.",
-                issue.number,
-                event.html_url().unwrap()
-            ), config.meeting_label.clone())
+            (
+                format!(
+                    "A new proposal has been announced: [#{}]({}). It will be
+                announced at the next meeting to try and draw attention to it,
+                but usually MCPs are not discussed during triage meetings. If
+                you think this would benefit from discussion amongst the
+                team, consider proposing a design meeting.",
+                    issue.number,
+                    event.html_url().unwrap()
+                ),
+                config.meeting_label.clone(),
+            )
         }
         Invocation::AcceptedProposal => {
             if !issue.labels().iter().any(|l| l.name == "major-change") {