Browse Source

Prevent non-Rust team members from assigning other users

Mark Rousskov 6 years ago
parent
commit
ea3c767610
1 changed files with 6 additions and 1 deletions
  1. 6 1
      src/handlers/assign.rs

+ 6 - 1
src/handlers/assign.rs

@@ -67,7 +67,12 @@ impl Handler for AssignmentHandler {
 
         let to_assign = match cmd {
             AssignCommand::Own => event.comment.user.login.clone(),
-            AssignCommand::User { username } => username.clone(),
+            AssignCommand::User { username } => {
+                if let Err(_) | Ok(false) = event.comment.user.is_team_member(&ctx.github) {
+                    failure::bail!("Only Rust team members can assign other users");
+                }
+                username.clone()
+            }
         };
 
         let e = EditIssueBody::new(&event.issue, "ASSIGN", String::new());